Bug 215017

Summary: Convert LinkHeader to use StringParsingBuffer
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2020-07-31 07:36:39 PDT
LinkHeader parsing should use StringParsingBuffer
Attachments
Patch (15.88 KB, patch)
2020-07-31 07:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-07-31 07:38:17 PDT
Created attachment 405692 [details] Patch
Darin Adler
Comment 2 2020-08-01 10:39:50 PDT
Comment on attachment 405692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405692&action=review > Source/WebCore/loader/LinkHeader.cpp:54 > - if ((chr >= '^' && chr <= 'z') || (chr >= 'A' && chr <= 'Z') || (chr >= '0' && chr <= '9') || (chr >= '!' && chr <= '$') || chr == '&' || chr == '+' || chr == '-' || chr == '.') > + if ((character >= '^' && character <= 'z') || (character >= 'A' && character <= 'Z') || (character >= '0' && character <= '9') || (character >= '!' && character <= '$') || character == '&' || character == '+' || character == '-' || character == '.') > return true; > return false; I’d like to see this be made shorter by using isASCIIAlphanumeric. Also, I’d like to use return rather than if return true else return false.
EWS
Comment 3 2020-08-01 10:51:22 PDT
Committed r265177: <https://trac.webkit.org/changeset/265177> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405692 [details].
Radar WebKit Bug Importer
Comment 4 2020-08-01 10:52:16 PDT
<rdar://problem/66427205>
Note You need to log in before you can comment on or make changes to this bug.