Bug 215014

Summary: Move user gesture propagation over promise behind a feature flag
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
eric.carlson: review+
Patch for landing none

youenn fablet
Reported 2020-07-31 00:33:23 PDT
Move user gesture propagation over promise behind a feature flag
Attachments
Patch (4.53 KB, patch)
2020-07-31 00:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (8.88 KB, patch)
2020-07-31 03:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (10.48 KB, patch)
2020-07-31 06:37 PDT, youenn fablet 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (9.22 KB, patch)
2020-08-03 17:26 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-07-31 00:36:19 PDT
Created attachment 405675 [details] Patch
youenn fablet
Comment 2 2020-07-31 03:49:19 PDT
Created attachment 405679 [details] Patch
youenn fablet
Comment 3 2020-07-31 06:37:05 PDT
Created attachment 405686 [details] Patch
Jiewen Tan
Comment 4 2020-07-31 12:38:36 PDT
Hi Youenn, Making user gesture being able to propagate through Fetch API is an important fix for this year's WebAuthn release. Can we have this feature turned on by default? Or we could make another scope just for WebAuthn. Is there any reasons you feel unsafe to turn on this feature?
youenn fablet
Comment 5 2020-07-31 14:31:14 PDT
> Is there any reasons you feel unsafe to turn on this feature? Do you know if we are matching Mozilla behavior for fetch? I guess we can turn on the feature for fetch and response getters. Some things in the implementation could be ironed out there but this should be fine. For ReadableStream, I think we should consolidate this and probably write a spec or at least get some discussion broader than WebKit.
Jiewen Tan
Comment 6 2020-07-31 19:19:45 PDT
Comment on attachment 405686 [details] Patch Didn't see this is enabled for WebKitTestRunner, but surprisedly WK2 bots are green.
Jiewen Tan
Comment 7 2020-08-03 17:26:19 PDT
Created attachment 405893 [details] Patch for landing
Jiewen Tan
Comment 8 2020-08-03 17:26:57 PDT
(In reply to Jiewen Tan from comment #7) > Created attachment 405893 [details] > Patch for landing After talking to Youenn, he agrees to make the feature default on. Therefore, uploaded a patch with that.
EWS
Comment 9 2020-08-03 18:05:14 PDT
Committed r265235: <https://trac.webkit.org/changeset/265235> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405893 [details].
Radar WebKit Bug Importer
Comment 10 2020-08-03 18:06:16 PDT
<rdar://problem/66501182>
Note You need to log in before you can comment on or make changes to this bug.