Bug 215010

Summary: Reduce over include usage in JSC
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, joepeck, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keith Miller
Reported 2020-07-30 22:05:53 PDT
Reduce over include usage in JSC
Attachments
Patch (9.83 KB, patch)
2020-07-30 22:08 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (10.36 KB, patch)
2020-07-30 22:18 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (10.37 KB, patch)
2020-07-30 23:25 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-07-30 22:08:31 PDT
Created attachment 405667 [details] Patch
Keith Miller
Comment 2 2020-07-30 22:18:59 PDT
Created attachment 405668 [details] Patch
Keith Miller
Comment 3 2020-07-30 23:25:24 PDT
Created attachment 405673 [details] Patch
Mark Lam
Comment 4 2020-07-31 00:10:49 PDT
Comment on attachment 405673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405673&action=review r=me if bots are happy. > Source/JavaScriptCore/runtime/VM.cpp:798 > +MacroAssemblerCodeRef<JITThunkPtrTag> VM::getCTIStub(ThunkGenerator generator) > +{ > + return jitStubs->ctiStub(*this, generator); > +} Optionally, this can go into VMInlines.h?
Keith Miller
Comment 5 2020-07-31 08:46:10 PDT
Comment on attachment 405673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405673&action=review >> Source/JavaScriptCore/runtime/VM.cpp:798 >> +} > > Optionally, this can go into VMInlines.h? Yeah, I don't think it's used anywhere really perf sensitive so I just put it here.
EWS
Comment 6 2020-07-31 09:00:31 PDT
Committed r265142: <https://trac.webkit.org/changeset/265142> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405673 [details].
Radar WebKit Bug Importer
Comment 7 2020-07-31 09:01:22 PDT
<rdar://problem/66383243>
Yusuke Suzuki
Comment 9 2020-08-02 16:05:42 PDT
Committed r265189: <https://trac.webkit.org/changeset/265189>
Keith Miller
Comment 10 2020-08-03 16:48:58 PDT
(In reply to Yusuke Suzuki from comment #9) > Committed r265189: <https://trac.webkit.org/changeset/265189> Thanks for the fix!
Note You need to log in before you can comment on or make changes to this bug.