| Summary: | Fix build around broken internal SDK for iOS 13 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, ews-watchlist, mark.lam, mitz, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Keith Miller
2020-07-30 21:59:36 PDT
Created attachment 405666 [details]
Patch
CCing people that know more about the build to make sure there's not a more reasonable fix. I don't really understand why we are able to locate the <machine/cpu_capabilities.h> header when building JSC but not when building TestWebKitAPI... Comment on attachment 405666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405666&action=review > Source/JavaScriptCore/assembler/FastJITPermissions.h:33 > +// FIXME: We only need this because the internal SDK is broken for an update of iOS 13... D: But since it shipped that way it's probably too late to fix. See: rdar://66350584 > +#define HAVE_THREAD_SELF_RESTRICT USE(APPLE_INTERNAL_SDK) && __has_include(<machine/cpu_capabilities.h>) this feels wrong. And could be indicative of other bugs. I'd prefer a better solution, but if this is all we have, better to unblock the build. Might be worth asking a few other folks who know the build system better. Also, please document what's going on in the radar Created attachment 405674 [details]
Patch
Comment on attachment 405674 [details]
Patch
r=me
Committed r265141: <https://trac.webkit.org/changeset/265141> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405674 [details]. |