Bug 215009

Summary: Fix build around broken internal SDK for iOS 13
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ews-watchlist, mark.lam, mitz, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2020-07-30 21:59:36 PDT
Fix build around broken internal SDK for iOS 13
Attachments
Patch (2.75 KB, patch)
2020-07-30 22:02 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.38 KB, patch)
2020-07-30 23:49 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-07-30 22:02:16 PDT
Created attachment 405666 [details] Patch
Keith Miller
Comment 2 2020-07-30 22:03:46 PDT
CCing people that know more about the build to make sure there's not a more reasonable fix. I don't really understand why we are able to locate the <machine/cpu_capabilities.h> header when building JSC but not when building TestWebKitAPI...
Saam Barati
Comment 3 2020-07-30 23:08:28 PDT
Comment on attachment 405666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405666&action=review > Source/JavaScriptCore/assembler/FastJITPermissions.h:33 > +// FIXME: We only need this because the internal SDK is broken for an update of iOS 13... D: But since it shipped that way it's probably too late to fix. See: rdar://66350584 > +#define HAVE_THREAD_SELF_RESTRICT USE(APPLE_INTERNAL_SDK) && __has_include(<machine/cpu_capabilities.h>) this feels wrong. And could be indicative of other bugs. I'd prefer a better solution, but if this is all we have, better to unblock the build. Might be worth asking a few other folks who know the build system better. Also, please document what's going on in the radar
Keith Miller
Comment 4 2020-07-30 23:49:49 PDT
Created attachment 405674 [details] Patch
Mark Lam
Comment 5 2020-07-30 23:53:10 PDT
Comment on attachment 405674 [details] Patch r=me
Keith Miller
Comment 6 2020-07-30 23:54:19 PDT
rdar://66350584
EWS
Comment 7 2020-07-31 08:54:34 PDT
Committed r265141: <https://trac.webkit.org/changeset/265141> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405674 [details].
Note You need to log in before you can comment on or make changes to this bug.