Bug 215000

Summary:

Add the ability of comparing the accessibility tree with isolated tree mode on and off.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

New Bugs

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Andres Gonzalez

Reported 2020-07-30 18:14:42 PDT

Add the ability of comparing the accessibility tree with isolated tree mode on and off.

Attachments
Patch (9.73 KB, patch) 2020-07-30 18:25 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (15.10 KB, patch) 2020-07-31 08:50 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (15.43 KB, patch) 2020-07-31 10:59 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (15.67 KB, patch) 2020-07-31 11:22 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (16.28 KB, patch) 2020-07-31 12:03 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (16.38 KB, patch) 2020-07-31 12:54 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (16.42 KB, patch) 2020-07-31 13:48 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (17.16 KB, patch) 2020-08-01 11:08 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (18.37 KB, patch) 2020-08-02 10:31 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (18.38 KB, patch) 2020-08-03 09:20 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (18.38 KB, patch) 2020-08-03 09:34 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (17.78 KB, patch) 2020-08-03 17:29 PDT, Andres Gonzalez	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Andres Gonzalez

Comment 1 2020-07-30 18:25:19 PDT

Created attachment 405650 [details] Patch

chris fleizach

Comment 2 2020-07-30 23:40:33 PDT

Comment on attachment 405650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405650&action=review > LayoutTests/accessibility/mac/isolated-tree-mode-on-off.html:20 > + if (window.accessibilityController) { side-but related topic- can we also add something to ensure that the isolated tree objects are returned? maybe we can return an attribute from the WebObjectWrapper that exists only when our backing object is an isolated tree object

Andres Gonzalez

Comment 3 2020-07-31 08:50:47 PDT

Created attachment 405696 [details] Patch

chris fleizach

Comment 4 2020-07-31 10:09:11 PDT

lots of build fails

Andres Gonzalez

Comment 5 2020-07-31 10:59:06 PDT

Created attachment 405708 [details] Patch

Andres Gonzalez

Comment 6 2020-07-31 11:22:13 PDT

Created attachment 405712 [details] Patch

Andres Gonzalez

Comment 7 2020-07-31 12:03:32 PDT

Created attachment 405719 [details] Patch

Andres Gonzalez

Comment 8 2020-07-31 12:54:16 PDT

Created attachment 405724 [details] Patch

Andres Gonzalez

Comment 9 2020-07-31 13:48:45 PDT

Created attachment 405734 [details] Patch

Andres Gonzalez

Comment 10 2020-08-01 11:08:32 PDT

Created attachment 405787 [details] Patch

chris fleizach

Comment 11 2020-08-01 11:20:07 PDT

Comment on attachment 405787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405787&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:379 > + return backingObject ? backingObject->isAXIsolatedObjectInstance() : NO; This could be return backingObject && backingObject->.....

Andres Gonzalez

Comment 12 2020-08-02 10:31:31 PDT

Created attachment 405811 [details] Patch

Andres Gonzalez

Comment 13 2020-08-03 09:20:21 PDT

Created attachment 405837 [details] Patch

chris fleizach

Comment 14 2020-08-03 09:25:53 PDT

Comment on attachment 405837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405837&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:379 > + return backingObject ? backingObject->isAXIsolatedObjectInstance() : NO; this could just be return backingObject && backingObject->isAXIsolatedObjectInstance();

Andres Gonzalez

Comment 15 2020-08-03 09:34:17 PDT

Created attachment 405840 [details] Patch

EWS

Comment 16 2020-08-03 16:15:30 PDT

Tools/Scripts/svn-apply failed to apply attachment 405840 [details] to trunk. Please resolve the conflicts and upload a new patch.

Andres Gonzalez

Comment 17 2020-08-03 17:29:20 PDT

Created attachment 405895 [details] Patch

EWS

Comment 18 2020-08-04 09:56:38 PDT

Committed r265248: <https://trac.webkit.org/changeset/265248> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405895 [details].

Radar WebKit Bug Importer

Comment 19 2020-08-04 09:57:17 PDT

<rdar://problem/66528080>

Note You need to log in before you can comment on or make changes to this bug.