Summary: | [macOS] Date/time input types should have a textfield appearance | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, m.kurz+webkitbugs, pdr, sam, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari Technology Preview | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Aditya Keerthi
2020-07-30 11:05:47 PDT
Created attachment 405596 [details]
Patch
Created attachment 405599 [details]
Patch
Created attachment 405694 [details]
Patch
Comment on attachment 405694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405694&action=review > Source/WebCore/rendering/RenderThemeMac.mm:402 > + return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s; This seems fine for now, but given that they’re all the same style rules, we might want to consider just refactoring these styles to be under something like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css as "input[type=date], input[type=time], … { … }". (In reply to Wenson Hsieh from comment #4) > Comment on attachment 405694 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405694&action=review > > > Source/WebCore/rendering/RenderThemeMac.mm:402 > > + return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s; > > This seems fine for now, but given that they’re all the same style rules, we > might want to consider just refactoring these styles to be under something > like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css > as "input[type=date], input[type=time], … { … }". Sounds good! I will be making more changes to the stylesheet in upcoming patches. Committed r265157: <https://trac.webkit.org/changeset/265157> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405694 [details]. |