Bug 214978

Summary: [macOS] Date/time input types should have a textfield appearance
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, m.kurz+webkitbugs, pdr, sam, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Aditya Keerthi
Reported 2020-07-30 11:05:47 PDT
...
Attachments
Patch (9.63 KB, patch)
2020-07-30 12:10 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (22.21 KB, patch)
2020-07-30 13:04 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (12.12 KB, patch)
2020-07-31 08:19 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-07-30 12:10:47 PDT
Created attachment 405596 [details] Patch
Aditya Keerthi
Comment 2 2020-07-30 13:04:35 PDT
Created attachment 405599 [details] Patch
Aditya Keerthi
Comment 3 2020-07-31 08:19:05 PDT
Created attachment 405694 [details] Patch
Wenson Hsieh
Comment 4 2020-07-31 12:39:41 PDT
Comment on attachment 405694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405694&action=review > Source/WebCore/rendering/RenderThemeMac.mm:402 > + return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s; This seems fine for now, but given that they’re all the same style rules, we might want to consider just refactoring these styles to be under something like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css as "input[type=date], input[type=time], … { … }".
Aditya Keerthi
Comment 5 2020-07-31 12:56:30 PDT
(In reply to Wenson Hsieh from comment #4) > Comment on attachment 405694 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405694&action=review > > > Source/WebCore/rendering/RenderThemeMac.mm:402 > > + return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s; > > This seems fine for now, but given that they’re all the same style rules, we > might want to consider just refactoring these styles to be under something > like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css > as "input[type=date], input[type=time], … { … }". Sounds good! I will be making more changes to the stylesheet in upcoming patches.
EWS
Comment 6 2020-07-31 13:19:06 PDT
Committed r265157: <https://trac.webkit.org/changeset/265157> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405694 [details].
Radar WebKit Bug Importer
Comment 7 2020-07-31 13:20:17 PDT
<rdar://problem/66395553>
Note You need to log in before you can comment on or make changes to this bug.