Bug 214960

Summary: Performance.getEntriesByName/Type should match case sensitive
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2020-07-30 00:24:11 PDT
Performance.getEntriesByName/Type should match case sensitive, see: https://w3c.github.io/performance-timeline/#getentriesbytype-method
Attachments
Patch (8.79 KB, patch)
2020-07-30 00:36 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (8.74 KB, patch)
2020-07-30 01:34 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-07-30 00:36:37 PDT
Created attachment 405555 [details] Patch
EWS Watchlist
Comment 2 2020-07-30 00:37:25 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Rob Buis
Comment 3 2020-07-30 01:34:29 PDT
Created attachment 405558 [details] Patch
youenn fablet
Comment 4 2020-07-31 03:13:17 PDT
Comment on attachment 405558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405558&action=review > LayoutTests/imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.js:6 > + var mixedList = self.performance.getEntriesByType("ReSoUrCe"); Can we add more tests for other strings: mark, measure, paint?
Rob Buis
Comment 5 2020-08-04 00:26:13 PDT
(In reply to youenn fablet from comment #4) > Comment on attachment 405558 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405558&action=review > > > LayoutTests/imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.js:6 > > + var mixedList = self.performance.getEntriesByType("ReSoUrCe"); > > Can we add more tests for other strings: mark, measure, paint? I added a test (https://github.com/web-platform-tests/wpt/pull/24826) but no review until now. I'll land the patch since I waited long enough now.
youenn fablet
Comment 6 2020-08-04 00:34:35 PDT
(In reply to Rob Buis from comment #5) > (In reply to youenn fablet from comment #4) > > Comment on attachment 405558 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=405558&action=review > > > > > LayoutTests/imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.js:6 > > > + var mixedList = self.performance.getEntriesByType("ReSoUrCe"); > > > > Can we add more tests for other strings: mark, measure, paint? > > I added a test (https://github.com/web-platform-tests/wpt/pull/24826) but no > review until now. I'll land the patch since I waited long enough now. I added a review.
EWS
Comment 7 2020-08-04 00:40:17 PDT
Committed r265243: <https://trac.webkit.org/changeset/265243> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405558 [details].
Radar WebKit Bug Importer
Comment 8 2020-08-04 00:41:20 PDT
<rdar://problem/66511734>
Rob Buis
Comment 9 2020-08-04 01:57:59 PDT
(In reply to youenn fablet from comment #6) > > I added a test (https://github.com/web-platform-tests/wpt/pull/24826) but no > > review until now. I'll land the patch since I waited long enough now. > > I added a review. Thanks! It landed now.
Note You need to log in before you can comment on or make changes to this bug.