Bug 214938

Summary: Highlight color does not switch after being set it system preferences.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Severity: Normal CC: thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
thorton: review+
thorton: review+
Patch none

Description Megan Gardner 2020-07-29 14:49:27 PDT
Highlight color does not switch after being set it system preferences.
Comment 1 Megan Gardner 2020-07-29 14:52:54 PDT
Created attachment 405507 [details]
Comment 2 Tim Horton 2020-07-29 14:57:23 PDT
Comment on attachment 405507 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=405507&action=review

> Source/WebKit/ChangeLog:9
> +        After the changes to the sandbox and how defaults are being transferred to the web process,

This should probably reference a commit.

> Source/WebKit/ChangeLog:11
> +        after setting the defaults so that the value is retried after it is actually set and we do

"value is retried" -> "cache is invalidated"

You might even mention which cache (colorCache in RenderTheme)...

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:953
> +        [notificationCenter postNotificationName:@"NSSystemColorsWillChangeNotification" object:nil];
> +        [notificationCenter postNotificationName:NSSystemColorsDidChangeNotification object:nil];

While it looks weird that "WillChange" and "DidChange" are adjacent without the change sitting between them, this does match what happens in AppKit.
Comment 3 Megan Gardner 2020-07-29 15:04:37 PDT
Created attachment 405508 [details]
Comment 4 Tim Horton 2020-07-29 15:09:31 PDT
Comment on attachment 405508 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=405508&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:933
> +static const WTF::String& userHighlightColorPreferenceKey()

Space above here.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:938
> +

Not here.
Comment 5 Megan Gardner 2020-07-29 15:30:53 PDT
Created attachment 405514 [details]
Comment 6 EWS 2020-07-29 18:00:27 PDT
Committed r265072: <https://trac.webkit.org/changeset/265072>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405514 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-29 18:01:17 PDT
Comment 8 Megan Gardner 2020-07-29 18:07:18 PDT