Bug 214925

Summary:

Make sure playback state constants remain on OscillatorNode for backward compatibility

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214902

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2020-07-29 10:53:30 PDT

Make sure playback state constants remain on OscillatorNode for backward compatibility, while we keep supporting the prefixed Web Audio API.

Comment 1 Chris Dumez 2020-07-29 10:54:58 PDT

Created attachment 405474 [details]
Patch

Comment 2 Eric Carlson 2020-07-29 10:57:05 PDT

Comment on attachment 405474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405474&action=review

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:41
> +    // Legacy Playback state constants kept for backward compatibility with the prefixed API.

You may want to add a comment that these will be removed at some point.

Comment 3 Chris Dumez 2020-07-29 10:59:55 PDT

Created attachment 405475 [details]
Patch

Comment 4 EWS 2020-07-29 12:12:51 PDT

Committed r265050: <https://trac.webkit.org/changeset/265050>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405475 [details].

Comment 5 Radar WebKit Bug Importer 2020-07-29 12:13:18 PDT

<rdar://problem/66285511>