Bug 214902 - Move non standard OscillatorNode API to new webKitOscillatorNode interface
Summary: Move non standard OscillatorNode API to new webKitOscillatorNode interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-07-28 15:51 PDT by Chris Dumez
Modified: 2020-07-29 10:56 PDT (History)
18 users (show)

See Also:


Attachments
Patch (26.72 KB, patch)
2020-07-28 17:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (26.72 KB, patch)
2020-07-28 18:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-07-28 15:51:08 PDT
Move non standard OscillatorNode API to new WebKitOscillatorNode interface, so that the unprefixed OscillatorNode is fully spec-compliant.
Comment 1 Chris Dumez 2020-07-28 17:09:53 PDT
Created attachment 405428 [details]
Patch
Comment 2 Darin Adler 2020-07-28 17:19:33 PDT
Comment on attachment 405428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405428&action=review

> Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:32
> +class WebKitOscillatorNode : public OscillatorNode {

final

> Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:46
> +    const char* activeDOMObjectName() const final { return "WebKitOscillatorNode"; }

private
Comment 3 Chris Dumez 2020-07-28 18:25:06 PDT
Created attachment 405431 [details]
Patch
Comment 4 EWS 2020-07-28 22:18:39 PDT
Committed r265028: <https://trac.webkit.org/changeset/265028>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405431 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-28 22:19:21 PDT
<rdar://problem/66255126>