Summary: | Special HID mapping for the Dualshock 3 controller | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | sam, thorton, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 214910 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Brady Eidson
2020-07-28 22:22:13 PDT
Created attachment 405651 [details]
Patch
Comment on attachment 405651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405651&action=review > Source/WebCore/platform/gamepad/GamepadConstants.h:30 > +#import <IOKit/hid/IOHIDUsageTables.h> This doesn't seem like this belongs in a platform file that is not OS(DARWIN) specific, or at least guarded by OS(DARWIN) in someway. (In reply to Sam Weinig from comment #3) > Comment on attachment 405651 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405651&action=review > > > Source/WebCore/platform/gamepad/GamepadConstants.h:30 > > +#import <IOKit/hid/IOHIDUsageTables.h> > > This doesn't seem like this belongs in a platform file that is not > OS(DARWIN) specific, or at least guarded by OS(DARWIN) in someway. Yup quite right. (In reply to Brady Eidson from comment #4) > (In reply to Sam Weinig from comment #3) > > Comment on attachment 405651 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=405651&action=review > > > > > Source/WebCore/platform/gamepad/GamepadConstants.h:30 > > > +#import <IOKit/hid/IOHIDUsageTables.h> > > > > This doesn't seem like this belongs in a platform file that is not > > OS(DARWIN) specific, or at least guarded by OS(DARWIN) in someway. > > Yup quite right. That said only the Darwin platforms are broken and all the linucies work lol Created attachment 405669 [details]
Patch
Comment on attachment 405669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405669&action=review > Source/WebCore/platform/gamepad/GamepadConstants.h:58 > +extern const size_t numberStandardGamepadButtonsWithoutHomeButton; number... Of? Created attachment 405718 [details]
Patch
Committed r265156: <https://trac.webkit.org/changeset/265156> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405718 [details]. |