Bug 214902

Summary: Move non standard OscillatorNode API to new webKitOscillatorNode interface
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, clark_wang, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214925
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-07-28 15:51:08 PDT
Move non standard OscillatorNode API to new WebKitOscillatorNode interface, so that the unprefixed OscillatorNode is fully spec-compliant.
Attachments
Patch (26.72 KB, patch)
2020-07-28 17:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (26.72 KB, patch)
2020-07-28 18:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-07-28 17:09:53 PDT
Created attachment 405428 [details] Patch
Darin Adler
Comment 2 2020-07-28 17:19:33 PDT
Comment on attachment 405428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405428&action=review > Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:32 > +class WebKitOscillatorNode : public OscillatorNode { final > Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:46 > + const char* activeDOMObjectName() const final { return "WebKitOscillatorNode"; } private
Chris Dumez
Comment 3 2020-07-28 18:25:06 PDT
Created attachment 405431 [details] Patch
EWS
Comment 4 2020-07-28 22:18:39 PDT
Committed r265028: <https://trac.webkit.org/changeset/265028> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405431 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-28 22:19:21 PDT
<rdar://problem/66255126>
Note You need to log in before you can comment on or make changes to this bug.