Bug 214879

Summary:

[build.webkit.org] Add Big Sur builder

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-feeder, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214863
https://bugs.webkit.org/show_bug.cgi?id=214874

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Jonathan Bedard

Reported 2020-07-28 09:19:31 PDT

We need to add a Big Sur Seed 3 builder to post-commit CI.

Attachments
Patch (4.21 KB, patch) 2020-07-28 09:22 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (6.05 KB, patch) 2020-07-28 10:15 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (6.68 KB, patch) 2020-07-28 10:20 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (5.95 KB, patch) 2020-07-28 10:36 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (5.92 KB, patch) 2020-07-28 12:24 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (2.01 KB, patch) 2020-07-29 07:01 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-07-28 09:19:49 PDT

<rdar://problem/66221071>

Jonathan Bedard

Comment 2 2020-07-28 09:22:36 PDT

Created attachment 405363 [details] Patch

Jonathan Bedard

Comment 3 2020-07-28 10:15:07 PDT

Created attachment 405371 [details] Patch

Jonathan Bedard

Comment 4 2020-07-28 10:20:54 PDT

Created attachment 405373 [details] Patch

Jonathan Bedard

Comment 5 2020-07-28 10:36:21 PDT

Created attachment 405376 [details] Patch

Aakash Jain

Comment 6 2020-07-28 11:21:29 PDT

Comment on attachment 405376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405376&action=review r+ with comments. > Tools/ChangeLog:3 > + [Big Sur] Add Seed 3 builder A better bug title might be: [build.webkit.org] Add Big Sur builder. The patch isn't specific to seed 3, 'seed 3' is a minor implementation detail. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:4 > + { "name": "bot279", "platform": "mac-bigsur"}, Might consider adding one more bot in the config right away, even if it would be ready after a while. One bot might not be enough for this queue. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:109 > + "triggers": [], triggers can be removed from here.

Jonathan Bedard

Comment 7 2020-07-28 12:24:26 PDT

Created attachment 405392 [details] Patch

Jonathan Bedard

Comment 8 2020-07-28 15:53:13 PDT

Landed: https://trac.webkit.org/changeset/265016/webkit

EWS

Comment 9 2020-07-28 16:16:49 PDT

Committed r265016: <https://trac.webkit.org/changeset/265016> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405392 [details].

Aakash Jain

Comment 10 2020-07-28 17:31:09 PDT

wkbuild.py might need update as well similar to https://trac.webkit.org/changeset/263300/webkit