Bug 214867

Summary: Add WebRTC tests exercising H264 with various resolutions and bitrates.
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-07-28 02:18:54 PDT
Add WebRTC tests exercising H264 with various resolutions and bitrates.
Attachments
Patch (10.50 KB, patch)
2020-07-28 02:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (14.07 KB, patch)
2020-07-28 06:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.50 KB, patch)
2020-07-28 10:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-07-28 02:23:30 PDT
Created attachment 405346 [details] Patch
youenn fablet
Comment 2 2020-07-28 06:06:54 PDT
Created attachment 405353 [details] Patch
youenn fablet
Comment 3 2020-07-28 07:18:32 PDT
Comment on attachment 405353 [details] Patch Tests seem to run slowly so I had to increase timeout. But it seems to run fine on EWS now. If tests end up being flaky, we might have to split them in individual files.
Eric Carlson
Comment 4 2020-07-28 09:28:58 PDT
Comment on attachment 405353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405353&action=review > LayoutTests/http/wpt/fetch/readableStreamDefaultController-overwriting-expected.txt:5 > + > +PASS Overwrite ReadableStreamDefaultController enqueue > +PASS Overwrite ReadableStreamDefaultController error > +PASS Overwrite ReadableStreamDefaultController close > + I don't think you meant to include this. > LayoutTests/http/wpt/fetch/readableStreamDefaultController-overwriting.html:11 > +<!DOCTYPE html> > +<script src='/resources/testharness.js'></script> > +<script src='/resources/testharnessreport.js'></script> > +<script> > + > +var controllerPrototype; > +const rs = new ReadableStream({ > + start: function(c) { > + controllerPrototype = Object.getPrototypeOf(c); > + } > +}); Ditto > LayoutTests/http/wpt/fetch/resources/lengthy-pass.py:7 > +import time > + > +def main(request, response): > + delay = 0.05 > + headers = [] > + if "delay" in request.GET: > + delay = float(request.GET.first("delay")) Ditto.
youenn fablet
Comment 5 2020-07-28 10:01:10 PDT
Created attachment 405369 [details] Patch for landing
youenn fablet
Comment 6 2020-07-28 10:01:28 PDT
> I don't think you meant to include this. Indeed, I removed them.
EWS
Comment 7 2020-07-28 14:05:02 PDT
Committed r265005: <https://trac.webkit.org/changeset/265005> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405369 [details].
Radar WebKit Bug Importer
Comment 8 2020-07-28 14:06:17 PDT
<rdar://problem/66236337>
Note You need to log in before you can comment on or make changes to this bug.