Bug 214844

Summary: [Big Sur] Wrap SPI in feature guards
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: WebCore Misc.Assignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, saagar, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214707
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Jonathan Bedard 2020-07-27 13:05:08 PDT
There is some Big Sur SPI declarations that should arguably be behind a feature flag.
Comment 1 Radar WebKit Bug Importer 2020-07-27 13:14:37 PDT
<rdar://problem/66178527>
Comment 2 Jonathan Bedard 2020-07-27 13:20:18 PDT
Created attachment 405306 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-07-27 13:25:02 PDT
Comment on attachment 405306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405306&action=review

> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:39
>  extern const NSImageHintKey NSImageHintSymbolFont;

Pre-existing issue, but this shouldn't be in #else, correct? We want the compiler to tell us if the type is incorrect.
Comment 4 Jonathan Bedard 2020-07-27 13:40:36 PDT
Created attachment 405307 [details]
Patch
Comment 5 EWS 2020-07-27 15:00:01 PDT
Committed r264946: <https://trac.webkit.org/changeset/264946>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405307 [details].
Comment 6 Saagar Jha 2020-07-28 11:47:19 PDT
Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes build errors :( I'll put up a new patch to move it back into.
Comment 7 Jonathan Bedard 2020-07-28 14:17:34 PDT
Reopening to attach new patch.
Comment 8 Jonathan Bedard 2020-07-28 14:17:35 PDT
Created attachment 405413 [details]
Patch for landing
Comment 9 Jonathan Bedard 2020-07-28 14:23:25 PDT
(In reply to Saagar Jha from comment #6)
> Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes
> build errors :( I'll put up a new patch to move it back into.

Oops! Build fix incoming. Bots will be up for Seed 3 shortly, so we'll be more formally defending this build.
Comment 10 EWS 2020-07-28 14:43:47 PDT
Committed r265010: <https://trac.webkit.org/changeset/265010>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405413 [details].