Bug 21480

Summary:

PluginInfo and MimeTypeInfo structs are defined in two header files used on windows

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
[1/1] Remove duplicate definitions of MimeTypeInfo and PluginInfo.	sam: review+

Tony Chang

Reported 2008-10-08 11:25:38 PDT

They're defined in PluginData.h and PluginInfoStore.h. There should be only one. Patch coming.

Attachments
[1/1] Remove duplicate definitions of MimeTypeInfo and PluginInfo. (1.50 KB, patch) 2008-10-08 11:26 PDT, Tony Chang	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2008-10-08 11:26:23 PDT

Created attachment 24193 [details] [1/1] Remove duplicate definitions of MimeTypeInfo and PluginInfo. They're already defined in PluginData.h. --- WebCore/ChangeLog | 11 +++++++++++ WebCore/plugins/PluginInfoStore.cpp | 1 + WebCore/plugins/PluginInfoStore.h | 14 -------------- 3 files changed, 12 insertions(+), 14 deletions(-)

Sam Weinig

Comment 2 2008-10-08 13:46:34 PDT

Comment on attachment 24193 [details] [1/1] Remove duplicate definitions of MimeTypeInfo and PluginInfo. Nice.

Darin Adler

Comment 3 2008-10-12 18:13:44 PDT

http://trac.webkit.org/changeset/37541

Note You need to log in before you can comment on or make changes to this bug.