Bug 214747

Summary: Crash under PreconnectTask::start()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cgarcia, ews-watchlist, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 214030    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-07-24 10:19:21 PDT
Crash under PreconnectTask::start():
Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x00000000000001c0)
[  0] 0x0000000196390188 WebKit`WebKit::NetworkProcess::preconnectTo(PAL::SessionID, WTF::ObjectIdentifier<WebKit::WebPageProxyIdentifierType>, WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::URL const&, WTF::String const&, WebCore::StoredCredentialsPolicy, WTF::Optional<WebKit::NavigatingToAppBoundDomain>) [inlined] WTF::RefPtr<WebKit::NetworkDataTask, WTF::DumbPtrTraits<WebKit::NetworkDataTask> >::operator bool() const at RefPtr.h:88:47

     0x0000000196390178:      mov x1, x20
     0x000000019639017c:      mov x2, x19
     0x0000000196390180:       bl 0x16a54c             ; WebKit::PreconnectTask::PreconnectTask at PreconnectTask.cpp:45
     0x0000000196390184:      ldr x8, [x21, #0x8]
 ->  0x0000000196390188:      ldr x0, [x8, #0x1c0]
     0x000000019639018c:      cbz x0, 0x1371a0         ; <+568> at NetworkLoad.cpp
     0x0000000196390190:      ldr x8, [x0]
     0x0000000196390194:    ldraa x9, [x8, #0x18]!
     0x0000000196390198:     movk x8, #0x7a89, lsl #48

[  0] 0x0000000196390188 WebKit`WebKit::NetworkProcess::preconnectTo(PAL::SessionID, WTF::ObjectIdentifier<WebKit::WebPageProxyIdentifierType>, WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::URL const&, WTF::String const&, WebCore::StoredCredentialsPolicy, WTF::Optional<WebKit::NavigatingToAppBoundDomain>) [inlined] WebKit::NetworkLoad::start() at NetworkLoad.cpp:75
       71  	}
       72  	
       73  	void NetworkLoad::start()
       74  	{
    -> 75  	    if (m_task)
       76  	        m_task->resume();
       77  	}
       78  	
       79  	NetworkLoad::~NetworkLoad()
    
[  0] 0x0000000196390188 WebKit`WebKit::NetworkProcess::preconnectTo(PAL::SessionID, WTF::ObjectIdentifier<WebKit::WebPageProxyIdentifierType>, WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::URL const&, WTF::String const&, WebCore::StoredCredentialsPolicy, WTF::Optional<WebKit::NavigatingToAppBoundDomain>) [inlined] WebKit::PreconnectTask::start() + 4 at PreconnectTask.cpp:67
       63  	}
       64  	
       65  	void PreconnectTask::start()
       66  	{
    -> 67  	    m_networkLoad->start();
       68  	}
       69  	
       70  	PreconnectTask::~PreconnectTask() = default;
       71  	
    
[  0] 0x0000000196390184 WebKit`WebKit::NetworkProcess::preconnectTo(PAL::SessionID, WTF::ObjectIdentifier<WebKit::WebPageProxyIdentifierType>, WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::URL const&, WTF::String const&, WebCore::StoredCredentialsPolicy, WTF::Optional<WebKit::NavigatingToAppBoundDomain>) + 540 at NetworkProcess.cpp:1432
       1428	    }
       1429	    parameters.storedCredentialsPolicy = storedCredentialsPolicy;
       1430	    parameters.shouldPreconnectOnly = PreconnectOnly::Yes;
       1431	
    -> 1432	    (new PreconnectTask(*this, sessionID, WTFMove(parameters), [](const WebCore::ResourceError&) { }))->start();
       1433	#else
       1434	    UNUSED_PARAM(url);
       1435	    UNUSED_PARAM(userAgent);
       1436	    UNUSED_PARAM(storedCredentialsPolicy);
Comment 1 Chris Dumez 2020-07-24 10:19:37 PDT
<rdar://problem/65989668>
Comment 2 Chris Dumez 2020-07-24 10:55:54 PDT
Created attachment 405165 [details]
Patch
Comment 3 Geoffrey Garen 2020-07-24 11:16:22 PDT
Comment on attachment 405165 [details]
Patch

r=me
Comment 4 EWS 2020-07-24 11:41:33 PDT
Committed r264846: <https://trac.webkit.org/changeset/264846>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405165 [details].