Bug 214676

Summary: [JSC] Do not use hardened Array for Intl supportedLocalesOf
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, sbarati, ticaiolima, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213425    
Attachments:
Description Flags
Patch none

Description Yusuke Suzuki 2020-07-23 01:09:52 PDT
https://github.com/tc39/ecma402/pull/278
Comment 1 Yusuke Suzuki 2020-07-23 01:41:41 PDT
Created attachment 405023 [details]
Patch
Comment 2 Caio Lima 2020-07-23 05:36:57 PDT
Comment on attachment 405023 [details]
Patch

Informal r+. This patch LGTM, but I have one question regarding Test262. Is this making some Test262 cases pass? If so, is it possible to update test expectations?
Comment 3 Mark Lam 2020-07-23 06:30:42 PDT
Comment on attachment 405023 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2020-07-23 22:04:30 PDT
(In reply to Caio Lima from comment #2)
> Comment on attachment 405023 [details]
> Patch
> 
> Informal r+. This patch LGTM, but I have one question regarding Test262. Is
> this making some Test262 cases pass? If so, is it possible to update test
> expectations?

Because https://trac.webkit.org/changeset/260349/webkit changed observable part, this does not affect on test262. This eliminates non observable but time-consuming + meaningless code.
Comment 5 EWS 2020-07-24 08:49:55 PDT
Committed r264827: <https://trac.webkit.org/changeset/264827>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405023 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-24 08:50:46 PDT
<rdar://problem/66055863>