Bug 214671

Summary: [CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: CMakeAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, don.olmstead, ews-watchlist, gyuyoung.kim, pvollan, ross.kirsling, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pvollan: review+

Fujii Hironori
Reported 2020-07-22 19:25:38 PDT
[CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin StructuredExceptionHandlerSuppressor is used only by AppleWin port (in Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.cpp) makesafeseh.asm causes building problem for WinCairo because it is using OBJECT library type for WebCore.
Attachments
Patch (3.27 KB, patch)
2020-07-22 19:29 PDT, Fujii Hironori 		pvollan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-07-22 19:29:52 PDT
Created attachment 405009 [details] Patch
Per Arne Vollan
Comment 2 2020-07-23 07:12:30 PDT
Comment on attachment 405009 [details] Patch R=me.
Fujii Hironori
Comment 3 2020-07-23 13:38:19 PDT
Thank you for the review. Committed r264786: <https://trac.webkit.org/r264786>
Note You need to log in before you can comment on or make changes to this bug.