Bug 214668

Summary: Fix missing exception checks below RTCPeerConnection.generateCertificate().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: WebCore JavaScriptAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
ysuzuki: review+
proposed patch.
none
proposed patch. none

Description Mark Lam 2020-07-22 17:55:43 PDT
<rdar://problem/65929975>
Comment 1 Mark Lam 2020-07-22 18:16:06 PDT
Created attachment 405005 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2020-07-22 18:23:24 PDT
Comment on attachment 405005 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2020-07-22 19:47:53 PDT
Created attachment 405010 [details]
proposed patch.

Previous fix has a bug.  Let's try this new one on the EWS.
Comment 4 Mark Lam 2020-07-22 21:29:02 PDT
Created attachment 405016 [details]
proposed patch.
Comment 5 Mark Lam 2020-07-22 22:16:54 PDT
Comment on attachment 405016 [details]
proposed patch.

EWS bots are green.  This is ready for a review.
Comment 6 Yusuke Suzuki 2020-07-22 22:21:25 PDT
Comment on attachment 405016 [details]
proposed patch.

r=me
Comment 7 Yusuke Suzuki 2020-07-23 01:43:48 PDT
Comment on attachment 405016 [details]
proposed patch.

Looks like EWS is green!
Comment 8 EWS 2020-07-23 01:49:46 PDT
Committed r264751: <https://trac.webkit.org/changeset/264751>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405016 [details].