Bug 214653

Summary: Update macOS Version macros
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: New BugsAssignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, dino, eric.carlson, ews-watchlist, graouts, jbedard, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, saam, thorton, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Conrad Shultz
Reported 2020-07-22 13:56:13 PDT
Update macOS version macros.
Attachments
Patch (61.95 KB, patch)
2020-07-22 14:16 PDT, Conrad Shultz 		no flags
DetailsFormatted DiffDiff
Patch (96.85 KB, patch)
2020-07-22 15:25 PDT, Conrad Shultz 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Conrad Shultz
Comment 1 2020-07-22 13:56:52 PDT
<rdar://problem/65929542>
Conrad Shultz
Comment 2 2020-07-22 14:16:10 PDT
Created attachment 404960 [details] Patch
EWS Watchlist
Comment 3 2020-07-22 14:17:10 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Conrad Shultz
Comment 4 2020-07-22 15:25:22 PDT
Created attachment 404983 [details] Patch
Tim Horton
Comment 5 2020-07-22 15:26:47 PDT
Comment on attachment 404983 [details] Patch This is somewhere between rs=me and r=me.
Conrad Shultz
Comment 6 2020-07-22 21:49:08 PDT
Committed r264746: <https://trac.webkit.org/changeset/264746>
Alexey Proskuryakov
Comment 7 2020-07-23 17:41:52 PDT
Comment on attachment 404983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404983&action=review > Source/JavaScriptCore/Configurations/Base.xcconfig:109 > TARGET_MAC_OS_X_VERSION_MAJOR_10_16 = 101600; Do we still need these?
Conrad Shultz
Comment 8 2020-07-23 18:40:52 PDT
(In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 404983 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404983&action=review > > > Source/JavaScriptCore/Configurations/Base.xcconfig:109 > > TARGET_MAC_OS_X_VERSION_MAJOR_10_16 = 101600; > > Do we still need these? I'm leaving them in for now in case anyone builds on, e.g., the first seed of Big Sur. I'd think we can remove them in due course.
Note You need to log in before you can comment on or make changes to this bug.