Bug 214649

Summary: updateRendering trace point should exclude SVG
Product: WebKit Reporter: Ben Nham <nham>
Component: WebKit Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ben Nham
Reported 2020-07-22 12:12:15 PDT
After r259830, the updateRendering tracepoint doesn't work as expected since we are calling the tracepoint reentrantly (the root page's Page::updateRendering calls the SVG page's Page::updateRendering). We should either exclude the SVG page from this tracepoint or change the tracepoint pass an extra arg to kdebug_trace that can be used to properly pair the beginning and end of the tracepoint.
Attachments
Patch (1.52 KB, patch)
2020-07-23 10:32 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-07-23 10:31:50 PDT
*** Bug 214691 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 2 2020-07-23 10:32:25 PDT
Created attachment 405055 [details] Patch
Geoffrey Garen
Comment 3 2020-07-23 10:34:37 PDT
Comment on attachment 405055 [details] Patch r=me
EWS
Comment 4 2020-07-23 11:25:25 PDT
Committed r264778: <https://trac.webkit.org/changeset/264778> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405055 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-23 11:26:17 PDT
<rdar://problem/66002353>
Note You need to log in before you can comment on or make changes to this bug.