Bug 214641

Summary: [32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Caio Lima
Reported 2020-07-22 07:29:35 PDT
...
Attachments
Patch (1.54 KB, patch)
2020-07-22 07:36 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2020-07-23 05:03 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2020-07-22 07:36:40 PDT
Created attachment 404921 [details] Patch
Mark Lam
Comment 2 2020-07-22 08:29:15 PDT
Comment on attachment 404921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404921&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:331 > + move UndefinedTag, r1 > + move 0, r0 Can you just put a comment above this that says that this is in little endian order? That will make it easier if anyone tries to make big endian work, and need to grep for search for places to make needed changes. A comment is cheap and can be so helpful here.
Caio Lima
Comment 3 2020-07-23 05:03:05 PDT
Created attachment 405033 [details] Patch
Caio Lima
Comment 4 2020-07-23 05:06:53 PDT
Comment on attachment 405033 [details] Patch Thank you very much for the review. I also added another comment in another place that is "little-endian" specific.
EWS
Comment 5 2020-07-23 05:51:56 PDT
Committed r264758: <https://trac.webkit.org/changeset/264758> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405033 [details].
Radar WebKit Bug Importer
Comment 6 2020-07-23 05:52:18 PDT
<rdar://problem/65987760>
Note You need to log in before you can comment on or make changes to this bug.