Bug 214619

Summary: Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, dino, hi, inspector-bugzilla-changes, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2020-07-21 15:53:17 PDT
.
Attachments
Patch (2.34 KB, patch)
2020-07-21 16:03 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2020-07-21 15:53:34 PDT
<rdar://65747521>
Blaze Burg
Comment 2 2020-07-21 16:03:35 PDT
Created attachment 404870 [details] Patch
Devin Rousso
Comment 3 2020-07-21 16:07:09 PDT
Comment on attachment 404870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review r=me > LayoutTests/inspector/canvas/memory.html:59 > + InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas."); NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check
Blaze Burg
Comment 4 2020-07-21 16:54:28 PDT
Comment on attachment 404870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review >> LayoutTests/inspector/canvas/memory.html:59 >> + InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas."); > > NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check It.. is. see expected results for the first test case.
EWS
Comment 5 2020-07-21 17:10:04 PDT
Committed r264683: <https://trac.webkit.org/changeset/264683> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404870 [details].
Note You need to log in before you can comment on or make changes to this bug.