Summary: | Fix FinalizationRegistry GC finalizer interation | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Keith Miller
2020-07-20 20:44:40 PDT
Created attachment 404791 [details]
Patch
Comment on attachment 404791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404791&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + Turns out when you remove the ith element from an table and you /an table/a Vector/. I think the data structure you're using is a Vector, right? Can you also check why the jsc EWS bot is failing? Please fix if it's your failure. Please file a bug if the failure is not yours. Thanks. Comment on attachment 404791 [details]
Patch
r=me too.
Created attachment 404846 [details]
Patch for landing
Created attachment 404847 [details]
Patch for landing
Comment on attachment 404846 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=404846&action=review > Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:113 > + ASSERT(vm.currentThreadIsHoldingAPILock() || (Thread::mayBeGCThread() && ticket->vm().heap.worldIsStopped())); Why ticket->vm()? You have the VM& right there. Created attachment 404848 [details]
Patch for landing
(In reply to Mark Lam from comment #7) > Comment on attachment 404846 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404846&action=review > > > Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:113 > > + ASSERT(vm.currentThreadIsHoldingAPILock() || (Thread::mayBeGCThread() && ticket->vm().heap.worldIsStopped())); > > Why ticket->vm()? You have the VM& right there. Fair enough, twas a copy paste artifact. Committed r264673: <https://trac.webkit.org/changeset/264673> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404848 [details]. |