Bug 214586

Summary: Fix FinalizationRegistry GC finalizer interation
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2020-07-20 20:44:40 PDT
Fix FinalizationRegistry GC finalizer interation
Attachments
Patch (4.05 KB, patch)
2020-07-20 20:53 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.55 KB, patch)
2020-07-21 12:00 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.96 KB, patch)
2020-07-21 12:04 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.95 KB, patch)
2020-07-21 12:07 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-07-20 20:53:20 PDT
Created attachment 404791 [details] Patch
Mark Lam
Comment 2 2020-07-20 22:04:26 PDT
Comment on attachment 404791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404791&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + Turns out when you remove the ith element from an table and you /an table/a Vector/. I think the data structure you're using is a Vector, right?
Mark Lam
Comment 3 2020-07-20 22:05:53 PDT
Can you also check why the jsc EWS bot is failing? Please fix if it's your failure. Please file a bug if the failure is not yours. Thanks.
Yusuke Suzuki
Comment 4 2020-07-21 07:47:39 PDT
Comment on attachment 404791 [details] Patch r=me too.
Keith Miller
Comment 5 2020-07-21 12:00:50 PDT
Created attachment 404846 [details] Patch for landing
Keith Miller
Comment 6 2020-07-21 12:04:30 PDT
Created attachment 404847 [details] Patch for landing
Mark Lam
Comment 7 2020-07-21 12:05:11 PDT
Comment on attachment 404846 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=404846&action=review > Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:113 > + ASSERT(vm.currentThreadIsHoldingAPILock() || (Thread::mayBeGCThread() && ticket->vm().heap.worldIsStopped())); Why ticket->vm()? You have the VM& right there.
Keith Miller
Comment 8 2020-07-21 12:07:09 PDT
Created attachment 404848 [details] Patch for landing
Keith Miller
Comment 9 2020-07-21 12:12:22 PDT
(In reply to Mark Lam from comment #7) > Comment on attachment 404846 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404846&action=review > > > Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:113 > > + ASSERT(vm.currentThreadIsHoldingAPILock() || (Thread::mayBeGCThread() && ticket->vm().heap.worldIsStopped())); > > Why ticket->vm()? You have the VM& right there. Fair enough, twas a copy paste artifact.
EWS
Comment 10 2020-07-21 12:37:02 PDT
Committed r264673: <https://trac.webkit.org/changeset/264673> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404848 [details].
Radar WebKit Bug Importer
Comment 11 2020-07-21 12:38:16 PDT
<rdar://problem/65897598>
Note You need to log in before you can comment on or make changes to this bug.