Bug 214569

Summary:

[WPE] WebPopupItem should always be forward declared as struct

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

Tools / Tests

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for landing	none

Description Adrian Perez 2020-07-20 13:40:16 PDT

../Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h:38:1: warning: class 'WebPopupItem' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]
class WebPopupItem;
^
../Source/WebKit/UIProcess/WebPageProxy.h:357:8: note: previous use is here
struct WebPopupItem;
       ^

Comment 1 Adrian Perez 2020-07-20 13:44:51 PDT

Created attachment 404754 [details]
Patch for landing

Comment 2 EWS 2020-07-20 15:16:46 PDT

Committed r264623: <https://trac.webkit.org/changeset/264623>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404754 [details].

Comment 3 Radar WebKit Bug Importer 2020-07-20 15:17:13 PDT

<rdar://problem/65850780>