Bug 214555

Summary: pluginElementCustomGetOwnPropertySlot() should support VMInquiry requests.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: WebCore JavaScriptAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch. ysuzuki: review+

Mark Lam
Reported 2020-07-20 09:42:27 PDT
<rdar://problem/65625807>
Attachments
proposed patch. (8.59 KB, patch)
2020-07-24 21:25 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (9.93 KB, patch)
2020-07-24 21:37 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-07-20 17:07:36 PDT
<rdar://problem/65855400>
Mark Lam
Comment 2 2020-07-24 21:25:05 PDT
Created attachment 405220 [details] proposed patch.
Mark Lam
Comment 3 2020-07-24 21:37:20 PDT
Created attachment 405221 [details] proposed patch.
Yusuke Suzuki
Comment 4 2020-07-25 21:20:10 PDT
Comment on attachment 405221 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=405221&action=review r=me > Source/JavaScriptCore/runtime/JSObjectInlines.h:136 > + if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject()) Let's put `UNLIKELY`. > Source/JavaScriptCore/runtime/JSObjectInlines.h:179 > + if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject()) Let's put UNLIKELY
Mark Lam
Comment 5 2020-07-25 22:12:06 PDT
Thanks for the review. I've applied the fixes. Landed in r264895: <http://trac.webkit.org/r264895>.
Note You need to log in before you can comment on or make changes to this bug.