| Summary: | REGRESSION(r264486): storage/indexeddb/structured-clone.html crashes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | Tools / Tests | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, alecflett, beidson, ews-watchlist, jsbell, sihui_liu, tsavell, webkit-bug-importer, youennf, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214447 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2020-07-17 09:37:02 PDT
Created attachment 404568 [details]
Patch
*** Bug 214450 has been marked as a duplicate of this bug. *** Committed r264524: <https://trac.webkit.org/changeset/264524> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404568 [details]. These two tests started failing on windows at the same time, after the changes in 264524 they are not timing out: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fblend-saturation.svg&test=storage%2Findexeddb%2Fstructured-clone-private.html&test=storage%2Findexeddb%2Fstructured-clone.html (In reply to Truitt Savell from comment #5) > These two tests started failing on windows at the same time, after the > changes in 264524 they are not timing out: > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fblend-saturation. > svg&test=storage%2Findexeddb%2Fstructured-clone-private. > html&test=storage%2Findexeddb%2Fstructured-clone.html They are *now* timing out (In reply to Truitt Savell from comment #6) > (In reply to Truitt Savell from comment #5) > > These two tests started failing on windows at the same time, after the > > changes in 264524 they are not timing out: > > https://results.webkit.org/?suite=layout-tests&suite=layout- > > tests&suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fblend-saturation. > > svg&test=storage%2Findexeddb%2Fstructured-clone-private. > > html&test=storage%2Findexeddb%2Fstructured-clone.html > > They are *now* timing out These two tests were skipped and now they can run on platforms other than windows. I will keep the test expectation on win to Skip and let the tests run other platforms. Created attachment 404612 [details]
Patch for landing
Tools/Scripts/svn-apply failed to apply attachment 404612 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 404614 [details]
skip the tests
Committed r264557: <https://trac.webkit.org/changeset/264557> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404614 [details]. # Fatal error in: /Volumes/Data/slave/catalina-debug/build/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/rtc_certificate_generator.cc, line 147 # last system error: 2 # Check failed: signaling_thread_->IsCurrent() Doesn't look like anything was fixed yet, so re-opening. Actually, there WAS a fix, it was just marked as obsolete patch. |
