Bug 214481

Summary: REGRESSION(r264486): storage/indexeddb/structured-clone.html crashes
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Tools / TestsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, alecflett, beidson, ews-watchlist, jsbell, sihui_liu, tsavell, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214447
Attachments:
Description Flags
Patch
none
Patch for landing
none
skip the tests none

Attachments
Patch (6.01 KB, patch)
2020-07-17 09:51 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.41 KB, patch)
2020-07-17 15:47 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
skip the tests (1.47 KB, patch)
2020-07-17 16:00 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2020-07-17 09:51:28 PDT
Created attachment 404568 [details] Patch
Truitt Savell
Comment 2 2020-07-17 10:18:52 PDT
*** Bug 214450 has been marked as a duplicate of this bug. ***
EWS
Comment 3 2020-07-17 11:34:51 PDT
Committed r264524: <https://trac.webkit.org/changeset/264524> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404568 [details].
Radar WebKit Bug Importer
Comment 4 2020-07-17 11:35:15 PDT
<rdar://problem/65735839>
Truitt Savell
Comment 6 2020-07-17 14:02:27 PDT
(In reply to Truitt Savell from comment #5) > These two tests started failing on windows at the same time, after the > changes in 264524 they are not timing out: > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fblend-saturation. > svg&test=storage%2Findexeddb%2Fstructured-clone-private. > html&test=storage%2Findexeddb%2Fstructured-clone.html They are *now* timing out
Sihui Liu
Comment 7 2020-07-17 15:45:48 PDT
(In reply to Truitt Savell from comment #6) > (In reply to Truitt Savell from comment #5) > > These two tests started failing on windows at the same time, after the > > changes in 264524 they are not timing out: > > https://results.webkit.org/?suite=layout-tests&suite=layout- > > tests&suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fblend-saturation. > > svg&test=storage%2Findexeddb%2Fstructured-clone-private. > > html&test=storage%2Findexeddb%2Fstructured-clone.html > > They are *now* timing out These two tests were skipped and now they can run on platforms other than windows. I will keep the test expectation on win to Skip and let the tests run other platforms.
Sihui Liu
Comment 8 2020-07-17 15:47:44 PDT
Created attachment 404612 [details] Patch for landing
EWS
Comment 9 2020-07-17 15:57:25 PDT
Tools/Scripts/svn-apply failed to apply attachment 404612 [details] to trunk. Please resolve the conflicts and upload a new patch.
Sihui Liu
Comment 10 2020-07-17 16:00:14 PDT
Created attachment 404614 [details] skip the tests
EWS
Comment 11 2020-07-17 16:52:29 PDT
Committed r264557: <https://trac.webkit.org/changeset/264557> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404614 [details].
Alexey Proskuryakov
Comment 12 2020-07-18 11:08:45 PDT
# Fatal error in: /Volumes/Data/slave/catalina-debug/build/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/rtc_certificate_generator.cc, line 147 # last system error: 2 # Check failed: signaling_thread_->IsCurrent() Doesn't look like anything was fixed yet, so re-opening.
Alexey Proskuryakov
Comment 13 2020-07-18 11:16:50 PDT
Actually, there WAS a fix, it was just marked as obsolete patch.
Note You need to log in before you can comment on or make changes to this bug.