| Summary: | GenerateCertificateAsync should be called on signaling thread | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||
| Component: | WebRTC | Assignee: | Sihui Liu <sihui_liu> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alecflett, beidson, eric.carlson, ews-watchlist, ggaren, glenn, hta, jer.noble, jsbell, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=214481 https://bugs.webkit.org/show_bug.cgi?id=214478 |
||||||||
| Attachments: |
|
||||||||
|
Description
Sihui Liu
2020-07-17 00:25:23 PDT
Created attachment 404545 [details]
Patch
The added test would crash: # Fatal error in: /Volumes/Data/worker/macOS-Mojave-Debug-Build-EWS/build/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/rtc_certificate_generator.cc, line 147 # last system error: 2 # Check failed: signaling_thread_->IsCurrent() Is this a duplicate of bug 214478? This was filed earlier, but that one is more comprehensive, listing more affected tests. Created attachment 404703 [details]
Patch
Comment on attachment 404703 [details]
Patch
r=me
Do we need to unskip storage/indexeddb/structured-clone-rtccertificate now? (In reply to Geoffrey Garen from comment #6) > Do we need to unskip storage/indexeddb/structured-clone-rtccertificate now? LayoutTests/storage/indexeddb/structured-clone.html does not contain any RTCCertificate use (after https://bugs.webkit.org/show_bug.cgi?id=214481) so it should no longer crash. We probably forgot to reenable it. We should probably readd RTCCertificate in the test and reenable it at the same time. Committed r264604: <https://trac.webkit.org/changeset/264604> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404703 [details]. |