| Summary: | Add a addition point for extra user media sandbox extensions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, andersca, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, pvollan, sam, sergio, webkit-bug-importer, wenson_hsieh, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2020-07-17 00:03:20 PDT
Created attachment 404540 [details]
Patch
Comment on attachment 404540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review > Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111 > + if (needsAppleCameraSandboxExtension) { > extensionCount++; > +#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE) > + extensionCount++; > +#endif > + } I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane. (In reply to Sam Weinig from comment #3) > I wonder if all this nonsense can be removed if we just modernized the > Handle and HandleArray code. I would bet (though don't really remember) it > stems from a time pre-move-only types, and now could probably be a lot more > sane. Yup. Comment on attachment 404540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review >> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111 >> + } > > I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane. Heh, I wondered (and complained to others!) about why it was written like this; that makes sense. Not to be fixed in this patch, though. Committed r264521: <https://trac.webkit.org/changeset/264521> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404540 [details]. |