Bug 214443

Summary: emitIsUndefined() should not special-case [[IsHTMLDDA]] objects
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214525
https://bugs.webkit.org/show_bug.cgi?id=215572
Attachments:
Description Flags
Patch none

Alexey Shvayka
Reported 2020-07-16 20:41:36 PDT
emitIsUndefined() should not special-case [[IsHTMLDDA]] objects
Attachments
Patch (35.27 KB, patch)
2020-07-16 20:44 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-07-16 20:44:01 PDT
Created attachment 404530 [details] Patch
Alexey Shvayka
Comment 2 2020-07-16 20:44:39 PDT
(In reply to Alexey Shvayka from comment #1) > Created attachment 404530 [details] > Patch Warmed-up runs, --outer 16: r264388 patch default-value-destructuring-array 116.6965+-6.7738 ? 119.2430+-4.7604 ? might be 1.0218x slower default-value-destructuring-object 67.0743+-2.4654 ^ 55.5882+-2.1022 ^ definitely 1.2066x faster default-value-function-parameters 33.3015+-0.2660 ^ 21.8662+-0.2948 ^ definitely 1.5230x faster <geometric> 63.7685+-1.2348 ^ 52.4954+-1.2752 ^ definitely 1.2147x faster
Yusuke Suzuki
Comment 3 2020-07-16 21:07:35 PDT
Comment on attachment 404530 [details] Patch r=me
EWS
Comment 4 2020-07-17 04:55:57 PDT
Committed r264504: <https://trac.webkit.org/changeset/264504> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404530 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-17 04:56:16 PDT
<rdar://problem/65720373>
Note You need to log in before you can comment on or make changes to this bug.