Bug 21444

Summary: SVGResourceClipper cleanUp
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
SVG clipping eric: review+

Dirk Schulze
Reported 2008-10-07 13:31:11 PDT
We can share the code of the different platforms, since it is nearly the same.
Attachments
SVG clipping (23.26 KB, patch)
2008-10-07 13:33 PDT, Dirk Schulze 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2008-10-07 13:33:32 PDT
Created attachment 24157 [details] SVG clipping I made the code platform independent. I tested the patch with Cairo and Qt. Wasn't able to test it for Cg yet.
Eric Seidel (no email)
Comment 2 2008-10-07 13:40:17 PDT
Comment on attachment 24157 [details] SVG clipping This looks fine from a CG perspective. I'll land it in my tree, run the tests and commit. Thanks for taking this on.
Adam Barth
Comment 3 2008-10-14 01:26:02 PDT
Eric, what is the status of this? Are you going to land it or should someone else? Assigning to Eric for resolution.
Eric Seidel (no email)
Comment 4 2008-11-14 13:42:35 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... D WebCore/svg/graphics/cairo/SVGResourceClipperCairo.cpp D WebCore/svg/graphics/cg/SVGResourceClipperCg.cpp D WebCore/svg/graphics/qt/SVGResourceClipperQt.cpp M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.pro M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/platform/graphics/GraphicsContext.h M WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp M WebCore/platform/graphics/cg/GraphicsContextCG.cpp M WebCore/platform/graphics/qt/GraphicsContextQt.cpp M WebCore/svg/graphics/SVGResourceClipper.cpp Committed r38405 This will affect our next Chromium merge (in a good way). :)
Note You need to log in before you can comment on or make changes to this bug.