[iOS 14] Some PassKit SPI is now API

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

There is some PassKit SPI that is API in iOS 14.

[Radar WebKit Bug Importer]

<rdar://problem/65695889>

[Jonathan Bedard]

Created attachment 404495 [details]
Patch

[Darin Adler]

Comment on attachment 404495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404495&action=review

> Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330
> +#ifndef __PKPAYMENTMERCHANTSESSION_H__

This is not the ideal way to resolve this. Long term we would want to remove this block entirely. Doing it this way means we could end up keeping this forever.

[Jonathan Bedard]

(In reply to Darin Adler from comment #3)
> Comment on attachment 404495 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404495&action=review
> 
> > Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330
> > +#ifndef __PKPAYMENTMERCHANTSESSION_H__
> 
> This is not the ideal way to resolve this. Long term we would want to remove
> this block entirely. Doing it this way means we could end up keeping this
> forever.

I agree, I only went with it because it will be temporary once we stop building iOS 13.

The other option would be to have version checks for both iOS and watchOS, which seemed worse to me.

[Darin Adler]

Adding both version checks is what would let us remove this eventually. Otherwise we will keep it forever and not remember why it’s there.

[Jonathan Bedard]

Created attachment 404531 [details]
Patch

[Jonathan Bedard]

Created attachment 404537 [details]
Patch

[EWS]

Committed r264506: <https://trac.webkit.org/changeset/264506>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404537 [details].