Bug 214427

Summary: XPC connection should be suspended before setting target queue
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch none

Per Arne Vollan
Reported 2020-07-16 15:13:07 PDT
An active XPC connection should be suspended before setting a new target queue.
Attachments
Patch (3.07 KB, patch)
2020-07-16 15:24 PDT, Per Arne Vollan 		darin: review+
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2020-07-16 17:13 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-07-16 15:24:26 PDT
Created attachment 404487 [details] Patch
Darin Adler
Comment 2 2020-07-16 16:47:37 PDT
Comment on attachment 404487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404487&action=review > Source/WTF/ChangeLog:3 > + XPC connection should be suspended before setting target queue Why?
Per Arne Vollan
Comment 3 2020-07-16 17:01:39 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 404487 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404487&action=review > > > Source/WTF/ChangeLog:3 > > + XPC connection should be suspended before setting target queue > > Why? According to logs, it is an error to set the target queue while the connection is active. I will update the change log. Thanks for reviewing!
Per Arne Vollan
Comment 4 2020-07-16 17:13:14 PDT
Created attachment 404498 [details] Patch
EWS
Comment 5 2020-07-16 18:00:50 PDT
Committed r264489: <https://trac.webkit.org/changeset/264489> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404498 [details].
Radar WebKit Bug Importer
Comment 6 2020-07-16 18:01:17 PDT
<rdar://problem/65699751>
Note You need to log in before you can comment on or make changes to this bug.