Bug 214427 - XPC connection should be suspended before setting target queue
Summary: XPC connection should be suspended before setting target queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-16 15:13 PDT by Per Arne Vollan
Modified: 2020-07-16 18:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2020-07-16 15:24 PDT, Per Arne Vollan 		darin: review+
Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2020-07-16 17:13 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-07-16 15:13:07 PDT 
An active XPC connection should be suspended before setting a new target queue.
Comment 1 Per Arne Vollan 2020-07-16 15:24:26 PDT 
Created attachment 404487 [details]
Patch
Comment 2 Darin Adler 2020-07-16 16:47:37 PDT 
Comment on attachment 404487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404487&action=review

> Source/WTF/ChangeLog:3
> +        XPC connection should be suspended before setting target queue

Why?
Comment 3 Per Arne Vollan 2020-07-16 17:01:39 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 404487 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404487&action=review
> 
> > Source/WTF/ChangeLog:3
> > +        XPC connection should be suspended before setting target queue
> 
> Why?

According to logs, it is an error to set the target queue while the connection is active. I will update the change log.

Thanks for reviewing!
Comment 4 Per Arne Vollan 2020-07-16 17:13:14 PDT 
Created attachment 404498 [details]
Patch
Comment 5 EWS 2020-07-16 18:00:50 PDT 
Committed r264489: <https://trac.webkit.org/changeset/264489>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404498 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-16 18:01:17 PDT 
<rdar://problem/65699751>