Bug 214414

Summary: Update WPT css directory
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214350
https://bugs.webkit.org/show_bug.cgi?id=214285
https://bugs.webkit.org/show_bug.cgi?id=214280
https://bugs.webkit.org/show_bug.cgi?id=214275
https://bugs.webkit.org/show_bug.cgi?id=214278
https://bugs.webkit.org/show_bug.cgi?id=214284
https://bugs.webkit.org/show_bug.cgi?id=214282
https://bugs.webkit.org/show_bug.cgi?id=214453
https://bugs.webkit.org/show_bug.cgi?id=214454
https://bugs.webkit.org/show_bug.cgi?id=214455
https://bugs.webkit.org/show_bug.cgi?id=214456
https://bugs.webkit.org/show_bug.cgi?id=214457
https://bugs.webkit.org/show_bug.cgi?id=214458
https://bugs.webkit.org/show_bug.cgi?id=214459
https://bugs.webkit.org/show_bug.cgi?id=214460
https://bugs.webkit.org/show_bug.cgi?id=214461
https://bugs.webkit.org/show_bug.cgi?id=214462
https://bugs.webkit.org/show_bug.cgi?id=214463
https://bugs.webkit.org/show_bug.cgi?id=214464
https://bugs.webkit.org/show_bug.cgi?id=214465
https://bugs.webkit.org/show_bug.cgi?id=214466
https://bugs.webkit.org/show_bug.cgi?id=214467
https://bugs.webkit.org/show_bug.cgi?id=214468
https://bugs.webkit.org/show_bug.cgi?id=214469
https://bugs.webkit.org/show_bug.cgi?id=214470
https://bugs.webkit.org/show_bug.cgi?id=214471
https://bugs.webkit.org/show_bug.cgi?id=214472
https://bugs.webkit.org/show_bug.cgi?id=214485
Bug Depends on:    
Bug Blocks: 213927    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2020-07-16 10:05:34 PDT
After updating the bigger parts of WPT css directory in different bugs (check see also field) ... let's update everything else. This is an update for the directories: css-align css-animations css-backgrounds css-box css-cascade css-color-adjust css-display css-fonts css-images css-inline css-lists css-logical css-masking css-multicol css-overflow css-overscroll-behavior css-position css-properties-values-api css-pseudo css-scoping css-shadow-parts css-shapes css-sizing css-syntax css-text css-text-decor css-transitions css-values cssom cssom-view geometry mediaqueries reference selectors
Attachments
Patch (4.49 MB, patch)
2020-07-16 10:12 PDT, Carlos Alberto Lopez Perez
no flags
Patch (4.65 MB, patch)
2020-07-16 17:20 PDT, Carlos Alberto Lopez Perez
no flags
Patch (4.64 MB, patch)
2020-07-16 17:29 PDT, Carlos Alberto Lopez Perez
no flags
Patch (4.85 MB, patch)
2020-07-17 06:39 PDT, Carlos Alberto Lopez Perez
no flags
Patch (4.85 MB, patch)
2020-07-17 08:44 PDT, Carlos Alberto Lopez Perez
no flags
Patch (4.85 MB, patch)
2020-07-17 10:11 PDT, Carlos Alberto Lopez Perez
no flags
Patch (4.85 MB, patch)
2020-07-17 10:57 PDT, Carlos Alberto Lopez Perez
no flags
Carlos Alberto Lopez Perez
Comment 1 2020-07-16 10:12:50 PDT
Created attachment 404460 [details] Patch Test EWS. ignore
Carlos Alberto Lopez Perez
Comment 2 2020-07-16 17:20:12 PDT
Created attachment 404500 [details] Patch Test EWS. ignore
Carlos Alberto Lopez Perez
Comment 3 2020-07-16 17:29:09 PDT
Created attachment 404502 [details] Patch Test EWS. ignore
Carlos Alberto Lopez Perez
Comment 4 2020-07-17 06:39:20 PDT
Created attachment 404556 [details] Patch Hopefully EWS will be green
Carlos Alberto Lopez Perez
Comment 5 2020-07-17 08:44:28 PDT
Chris Dumez
Comment 6 2020-07-17 09:48:49 PDT
Looks like imported/w3c/web-platform-tests/css/css-display/display-first-line-002.html is failing.
Carlos Alberto Lopez Perez
Comment 7 2020-07-17 10:11:08 PDT
Carlos Alberto Lopez Perez
Comment 8 2020-07-17 10:12:52 PDT
(In reply to Chris Dumez from comment #6) > Looks like > imported/w3c/web-platform-tests/css/css-display/display-first-line-002.html > is failing. Right. I have updated the patch. Diff from previous: http://sprunge.us/GiudIS I had already marked it, but only for GTK and WPE. Now moved to the general expectation.
EWS
Comment 9 2020-07-17 10:52:35 PDT
Tools/Scripts/svn-apply failed to apply attachment 404571 [details] to trunk. Please resolve the conflicts and upload a new patch.
Carlos Alberto Lopez Perez
Comment 10 2020-07-17 10:57:09 PDT
Created attachment 404573 [details] Patch Patch for landing
EWS
Comment 11 2020-07-17 11:27:32 PDT
Committed r264522: <https://trac.webkit.org/changeset/264522> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404573 [details].
Radar WebKit Bug Importer
Comment 12 2020-07-17 11:28:21 PDT
Truitt Savell
Comment 13 2020-07-17 16:17:22 PDT
Reverted r264549 for reason: Expectation made in the wrong folder Committed r264550: <https://trac.webkit.org/changeset/264550>
Truitt Savell
Comment 14 2020-07-17 16:20:07 PDT
I made a change to the wrong file location in https://trac.webkit.org/changeset/264549/webkit and just corrected it. when the rebase of compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt was done it was not actually needed for production bots given the history and diffs: https://results.webkit.org/?suite=layout-tests&test=compositing%2Frepaint%2Fiframes%2Fcompositing-iframe-scroll-repaint.html I am correcting this now
Truitt Savell
Comment 15 2020-07-17 16:25:47 PDT
Truitt Savell
Comment 16 2020-07-17 16:42:31 PDT
The rebasline of imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox.html doesn't look like it was necessary for trunk bots. can you confirm? tracking in https://bugs.webkit.org/show_bug.cgi?id=214510
Note You need to log in before you can comment on or make changes to this bug.