Bug 214275 - Update WPT tests for css-text
Summary: Update WPT tests for css-text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks: 213927
  Show dependency treegraph
 
Reported: 2020-07-13 14:44 PDT by Carlos Alberto Lopez Perez
Modified: 2020-07-16 10:06 PDT (History)
8 users (show)

See Also:


Attachments
test patch for EWS, ignore (3.28 MB, patch)
2020-07-13 14:47 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (3.60 MB, patch)
2020-07-13 19:24 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (3.60 MB, patch)
2020-07-14 03:37 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (3.60 MB, patch)
2020-07-14 06:18 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-07-13 14:44:39 PDT
Update WPT tests for css/css-text
Comment 1 Carlos Alberto Lopez Perez 2020-07-13 14:47:33 PDT
Created attachment 404177 [details]
test patch for EWS, ignore
Comment 2 Carlos Alberto Lopez Perez 2020-07-13 19:24:21 PDT
Created attachment 404203 [details]
Patch

Hopefully all EWS will be green, let's see
Comment 3 Carlos Alberto Lopez Perez 2020-07-14 03:37:02 PDT
Created attachment 404219 [details]
Patch
Comment 4 Carlos Alberto Lopez Perez 2020-07-14 04:57:42 PDT
All green. Asking for review: r?
Comment 5 Manuel Rego Casasnovas 2020-07-14 05:33:41 PDT
Comment on attachment 404219 [details]
Patch

Thanks.
Comment 6 Carlos Alberto Lopez Perez 2020-07-14 06:18:07 PDT
Again getting issues with the tooling.. when trying to land this manually i get -E2BIG error.

$ Tools/Scripts/webkit-patch land -g HEAD
Logging in as clopez@igalia.com...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=214275&ctype=xml&excludefield=attachmentdata
Guessing "Manuel Rego Casasnovas" as reviewer from attachment 404219 [details] on bug 214275.
Total errors found: 0 in 6 files
COMMIT FAILED: [Errno 7] Argument list too long
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/steps/commit.py", line 89, in run
    svn_revision = scm.svn_revision_from_commit_text(commit_text)
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 106, in svn_revision_from_commit_text
    return match.group('svn_revision')
AttributeError: 'NoneType' object has no attribute 'group'

let's try commit-queue to see if that works better
Comment 7 Carlos Alberto Lopez Perez 2020-07-14 06:18:56 PDT
Created attachment 404229 [details]
Patch

Patch for landing
Comment 8 EWS 2020-07-14 07:06:29 PDT
Committed r264338: <https://trac.webkit.org/changeset/264338>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404229 [details].
Comment 9 Radar WebKit Bug Importer 2020-07-16 10:06:29 PDT
<rdar://problem/65673010>