Bug 214406

Summary: [LFC][IFC] adjustBaselineAndLineHeight should take the parent inline box.
Product: WebKit Reporter: alan baradlay <zalan>
Component: Layout and RenderingAssignee: alan baradlay <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215087, 215752    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan baradlay
Reported 2020-07-16 08:19:25 PDT
This is a preparation for multiple line boxes on the line.
Attachments
Patch (41.13 KB, patch)
2020-07-16 08:57 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (41.26 KB, patch)
2020-07-16 19:37 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (41.96 KB, patch)
2020-07-16 19:57 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (37.25 KB, patch)
2020-07-16 20:16 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (37.19 KB, patch)
2020-08-22 16:26 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan baradlay
Comment 1 2020-07-16 08:57:41 PDT
Created attachment 404442 [details] Patch
alan baradlay
Comment 2 2020-07-16 19:37:19 PDT
Created attachment 404519 [details] Patch
alan baradlay
Comment 3 2020-07-16 19:57:04 PDT
Created attachment 404522 [details] Patch
alan baradlay
Comment 4 2020-07-16 20:16:49 PDT
Created attachment 404527 [details] Patch
Radar WebKit Bug Importer
Comment 5 2020-07-23 08:20:16 PDT
<rdar://problem/65992768>
Antti Koivisto
Comment 6 2020-08-22 10:42:38 PDT
Comment on attachment 404527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404527&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:227 > + InlineBox m_lineBox; Maybe the names should match?
alan baradlay
Comment 7 2020-08-22 16:26:26 PDT
Created attachment 407059 [details] Patch
EWS
Comment 8 2020-08-22 18:15:06 PDT
Committed r266040: <https://trac.webkit.org/changeset/266040> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407059 [details].
alan baradlay
Comment 9 2020-08-22 19:46:09 PDT
(In reply to Antti Koivisto from comment #6) > Comment on attachment 404527 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404527&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:227 > > + InlineBox m_lineBox; > > Maybe the names should match? Maybe they should!
Note You need to log in before you can comment on or make changes to this bug.