Bug 214400

Summary: Double tapping to zoom out a fullscreen video will zoom in slightly before zooming out
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
A better patch none

Peng Liu
Reported 2020-07-15 23:26:01 PDT
Double tapping to zoom out a fullscreen video will zoom in slightly before zooming out
Attachments
Patch (5.91 KB, patch)
2020-07-15 23:53 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
A better patch (6.08 KB, patch)
2020-07-16 10:23 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2020-07-15 23:26:47 PDT
<rdar://problem/64579374>
Peng Liu
Comment 2 2020-07-15 23:53:10 PDT
Created attachment 404426 [details] Patch
Peng Liu
Comment 3 2020-07-16 10:04:19 PDT
Comment on attachment 404426 [details] Patch This patch handles two video gravity changes differently: 1) AVLayerVideoGravityResizeAspect -> AVLayerVideoGravityResizeAspectFill, 2) AVLayerVideoGravityResizeAspectFill -> AVLayerVideoGravityResizeAspect). The animation happens on the UI process for 1), and the animation happens on the web process for 2). We had better let the animations happen on the UI process for both cases.
Peng Liu
Comment 4 2020-07-16 10:23:36 PDT
Created attachment 404461 [details] A better patch
EWS
Comment 5 2020-07-16 10:59:27 PDT
Committed r264471: <https://trac.webkit.org/changeset/264471> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404461 [details].
Note You need to log in before you can comment on or make changes to this bug.