Bug 214380

Summary:

[WebAuthn] Add a console message: "User gesture is required to use the platform authenticator."

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebKit Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, ews-watchlist, hi, jiewen_tan, mkwst, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	hi: review+
Patch for landing	none

Jiewen Tan

Reported 2020-07-15 15:24:00 PDT

Add a console message: "User gesture is required to use the platform authenticator." when the user gesture is not presented.

Attachments
Patch (3.35 KB, patch) 2020-07-15 15:29 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Patch (37.41 KB, patch) 2020-07-15 17:37 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Patch (38.13 KB, patch) 2020-07-16 11:33 PDT, Jiewen Tan	hi: review+	Details Formatted Diff Diff
Patch for landing (50.25 KB, patch) 2020-07-16 17:22 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jiewen Tan

Comment 1 2020-07-15 15:24:34 PDT

<rdar://problem/65300587>

Jiewen Tan

Comment 2 2020-07-15 15:29:25 PDT

Created attachment 404400 [details] Patch

Jiewen Tan

Comment 3 2020-07-15 17:37:41 PDT

Created attachment 404407 [details] Patch

Jiewen Tan

Comment 4 2020-07-16 11:33:33 PDT

Created attachment 404470 [details] Patch

Devin Rousso

Comment 5 2020-07-16 12:22:18 PDT

Comment on attachment 404470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404470&action=review r=me > Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:57 > + m_webPage.addConsoleMessage(webFrame->frameID(), MessageSource::Other, MessageLevel::Warning, "User gesture is required to use the platform authenticator."_s); Is there any way we can make this message more descriptive? There's barely anything actionable here for a developer to use. The fact that every log is the exact same in the LayoutTests is indicative of the problem :( Also, can you add `#include <JavaScriptCore/ConsoleTypes.h>`?

Jiewen Tan

Comment 6 2020-07-16 17:17:16 PDT

Comment on attachment 404470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404470&action=review Thanks Devin for r+ this patch. >> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:57 >> + m_webPage.addConsoleMessage(webFrame->frameID(), MessageSource::Other, MessageLevel::Warning, "User gesture is required to use the platform authenticator."_s); > > Is there any way we can make this message more descriptive? There's barely anything actionable here for a developer to use. The fact that every log is the exact same in the LayoutTests is indicative of the problem :( > > Also, can you add `#include <JavaScriptCore/ConsoleTypes.h>`? Fixed the sentence and the header. Unfortunately, the web process doesn't have the necessary information to make a more fine grained message. Since this is a warning and for people that need it, it should be very clear for them. Therefore, the granularity here should be sufficient.

Jiewen Tan

Comment 7 2020-07-16 17:22:35 PDT

Created attachment 404501 [details] Patch for landing

EWS

Comment 8 2020-07-16 18:07:32 PDT

Committed r264490: <https://trac.webkit.org/changeset/264490> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404501 [details].

Note You need to log in before you can comment on or make changes to this bug.