Bug 214372

Summary: [ews] clicking submit for EWS analysis button for patches on closed bug should display error
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210803
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-07-15 13:22:09 PDT
Clicking 'submit for EWS analysis' button for patches on closed bug should display error, and such patches shouldn't be sent to EWS (buildbot). This is because the first thing our Buildbot builders do is to validate-patch, which will skip the patch if the corresponding bug is closed. Therefore sending the patch to Buildbot is useless, and might be confusing for users. It's better to display an error that the patch is not being sent to EWS since the corresponding bug is already closed.
Attachments
Patch (6.42 KB, patch)
2020-07-15 13:27 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-07-15 13:27:24 PDT
Created attachment 404384 [details] Patch
Aakash Jain
Comment 2 2020-07-15 13:28:30 PDT
Tested in https://ews.webkit-uat.org/status-bubble/404379 (feel free to click the button to check the new behavior)
EWS
Comment 3 2020-07-15 14:18:06 PDT
Committed r264421: <https://trac.webkit.org/changeset/264421> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404384 [details].
Radar WebKit Bug Importer
Comment 4 2020-07-15 14:19:18 PDT
<rdar://problem/65626564>
Aakash Jain
Comment 5 2020-07-15 14:42:45 PDT
> Committed r264421: <https://trac.webkit.org/changeset/264421> Deployed it on the server.
Note You need to log in before you can comment on or make changes to this bug.