| Summary: | [run-javascriptcore-tests] nativeArchitecture should never be arm64e | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ryanhaddad, saam, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari 13 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jonathan Bedard
2020-07-15 12:07:13 PDT
Created attachment 404371 [details]
Patch
Committed r264416: <https://trac.webkit.org/changeset/264416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404371 [details]. (In reply to Jonathan Bedard from comment #0) > For internal builds, architecture should be arm64e by default, but native > architecture should be arm64. What’s the distinction for? These function names make it difficult to see what it’s used for and why your fix is needed. (Agreed, I think we need better names or comments about why this is so wacky) (In reply to Saam Barati from comment #4) > (In reply to Jonathan Bedard from comment #0) > > For internal builds, architecture should be arm64e by default, but native > > architecture should be arm64. > > What’s the distinction for? These function names make it difficult to see > what it’s used for and why your fix is needed. 'architecture' means 'the architecture the user intends to build or test with' while 'native architecture' means 'the architecture that a machine will use to run code' Renaming probably isn't practical (since architecture is used in code not checked into WebKit), so comments are probably the way to go. |