Bug 214369

Summary: [run-javascriptcore-tests] nativeArchitecture should never be arm64e
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad, saam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 13   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2020-07-15 12:07:13 PDT
For internal builds, architecture should be arm64e by default, but native architecture should be arm64.
Attachments
Patch (1.60 KB, patch)
2020-07-15 12:12 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-07-15 12:08:38 PDT
<rdar://problem/65364995>
Jonathan Bedard
Comment 2 2020-07-15 12:12:54 PDT
Created attachment 404371 [details] Patch
EWS
Comment 3 2020-07-15 13:03:22 PDT
Committed r264416: <https://trac.webkit.org/changeset/264416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404371 [details].
Saam Barati
Comment 4 2020-07-15 13:05:50 PDT
(In reply to Jonathan Bedard from comment #0) > For internal builds, architecture should be arm64e by default, but native > architecture should be arm64. What’s the distinction for? These function names make it difficult to see what it’s used for and why your fix is needed.
Tim Horton
Comment 5 2020-07-15 13:07:00 PDT
(Agreed, I think we need better names or comments about why this is so wacky)
Jonathan Bedard
Comment 6 2020-07-15 14:00:21 PDT
(In reply to Saam Barati from comment #4) > (In reply to Jonathan Bedard from comment #0) > > For internal builds, architecture should be arm64e by default, but native > > architecture should be arm64. > > What’s the distinction for? These function names make it difficult to see > what it’s used for and why your fix is needed. 'architecture' means 'the architecture the user intends to build or test with' while 'native architecture' means 'the architecture that a machine will use to run code' Renaming probably isn't practical (since architecture is used in code not checked into WebKit), so comments are probably the way to go.
Note You need to log in before you can comment on or make changes to this bug.