Bug 214362

Summary: itsnicethat.com page is sometimes non-scrollable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: UI EventsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dbates, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214367
Attachments:
Description Flags
Patch
thorton: review+
Patch for EWS ews-feeder: commit-queue-

Description Simon Fraser (smfr) 2020-07-15 11:01:08 PDT 
itsnicethat.com page is sometimes non-scrollable
Comment 1 Simon Fraser (smfr) 2020-07-15 11:07:30 PDT 
Created attachment 404359 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-07-15 11:07:33 PDT 
<rdar://problem/65431127>
Comment 3 Tim Horton 2020-07-15 11:11:42 PDT 
Comment on attachment 404359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404359&action=review

> Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:113
> +    if ([self.mask isKindOfClass:[CAShapeLayer class]]) {
> +        CAShapeLayer *shapeMask = static_cast<CAShapeLayer *>(self.mask);

I think you can merge these two lines with a dynamic_objc_cast (same above)
Comment 4 Simon Fraser (smfr) 2020-07-15 11:24:12 PDT 
Created attachment 404361 [details]
Patch for EWS
Comment 5 EWS 2020-07-15 12:55:13 PDT 
Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog
Comment 6 Simon Fraser (smfr) 2020-07-15 13:02:53 PDT 
https://trac.webkit.org/changeset/264415/webkit