Bug 214355

Summary: [ews-app] Add timeout to network requests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218994
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-07-15 08:24:05 PDT
Sometimes network requests can get stuck or take very long time. on ews-app it can introduce delays in patch submissions from EWS django app to Buildbot. We should add an explicit timeout to network requests, so that the network request is timely terminated and retried in subsequent iteration of ews-app appropriately.
Attachments
Patch (1.58 KB, patch)
2020-07-15 08:27 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-07-15 08:27:48 PDT
Created attachment 404343 [details] Patch
Aakash Jain
Comment 2 2020-07-15 08:28:56 PDT
As per https://requests.readthedocs.io/en/master/user/quickstart/#timeouts: "Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely"
Aakash Jain
Comment 3 2020-07-15 08:39:44 PDT
In the past, I noticed few times ews-app getting stuck and not submitting patches to Buildbot for long time (even though the status-bubbles and /results kept working fine), restarting ews-app helped at those times. I believe I finally got to the bottom of the issue.
EWS
Comment 4 2020-07-15 09:24:27 PDT
Committed r264399: <https://trac.webkit.org/changeset/264399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404343 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-15 09:25:13 PDT
<rdar://problem/65609376>
Note You need to log in before you can comment on or make changes to this bug.