Summary: | [ews-app] Add timeout to network requests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=218994 | ||||||
Attachments: |
|
Description
Aakash Jain
2020-07-15 08:24:05 PDT
Created attachment 404343 [details]
Patch
As per https://requests.readthedocs.io/en/master/user/quickstart/#timeouts: "Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely" In the past, I noticed few times ews-app getting stuck and not submitting patches to Buildbot for long time (even though the status-bubbles and /results kept working fine), restarting ews-app helped at those times. I believe I finally got to the bottom of the issue. Committed r264399: <https://trac.webkit.org/changeset/264399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404343 [details]. |