Summary: | Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
Component: | JavaScriptCore | Assignee: | Alexey Shvayka <ashvayka> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Enhancement | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=212248 | ||||||||
Attachments: |
|
Description
Alexey Shvayka
2020-07-14 14:58:45 PDT
Created attachment 404290 [details]
Patch
(In reply to Alexey Shvayka from comment #1) > Created attachment 404290 [details] > Patch Warmed-up runs, --outer 50: r264266 patch has-own-property-for-in-loop-with-heap-variable 35.9192+-2.6893 ^ 29.2597+-0.7042 ^ definitely 1.2276x faster Comment on attachment 404290 [details]
Patch
Let's hold off on committing this until after the EWS bots finish testing. Thanks.
Comment on attachment 404290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review Good call. I think I was mistakenly thinking of "Reflect.has" when I wrote the code. r=me too > JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7 > - let o = { let's add a new test. Comment on attachment 404290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review >> JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7 >> - let o = { > > let's add a new test. By "let's add a new test", I think Saam meant, let's not modify this one, but add a clone of this one that uses Reflect instead. Comment on attachment 404290 [details]
Patch
Removing the cq? because the test needs to be updated. I would still like to see the EWS tests run to completion on this patch (since they are almost there already).
Created attachment 404323 [details]
Patch
Clone test instead of modifying.
Committed r264397: <https://trac.webkit.org/changeset/264397> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404323 [details]. |