Bug 214325

Summary: Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212248
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2020-07-14 14:58:45 PDT
Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers
Attachments
Patch (4.13 KB, patch)
2020-07-14 15:01 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (4.16 KB, patch)
2020-07-15 00:36 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-07-14 15:01:48 PDT
Created attachment 404290 [details] Patch
Alexey Shvayka
Comment 2 2020-07-14 15:02:23 PDT
(In reply to Alexey Shvayka from comment #1) > Created attachment 404290 [details] > Patch Warmed-up runs, --outer 50: r264266 patch has-own-property-for-in-loop-with-heap-variable 35.9192+-2.6893 ^ 29.2597+-0.7042 ^ definitely 1.2276x faster
Mark Lam
Comment 3 2020-07-14 15:49:05 PDT
Comment on attachment 404290 [details] Patch Let's hold off on committing this until after the EWS bots finish testing. Thanks.
Saam Barati
Comment 4 2020-07-14 16:56:56 PDT
Comment on attachment 404290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review Good call. I think I was mistakenly thinking of "Reflect.has" when I wrote the code. r=me too > JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7 > - let o = { let's add a new test.
Mark Lam
Comment 5 2020-07-14 17:14:49 PDT
Comment on attachment 404290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review >> JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7 >> - let o = { > > let's add a new test. By "let's add a new test", I think Saam meant, let's not modify this one, but add a clone of this one that uses Reflect instead.
Mark Lam
Comment 6 2020-07-14 17:17:25 PDT
Comment on attachment 404290 [details] Patch Removing the cq? because the test needs to be updated. I would still like to see the EWS tests run to completion on this patch (since they are almost there already).
Alexey Shvayka
Comment 7 2020-07-15 00:36:13 PDT
Created attachment 404323 [details] Patch Clone test instead of modifying.
EWS
Comment 8 2020-07-15 07:47:48 PDT
Committed r264397: <https://trac.webkit.org/changeset/264397> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404323 [details].
Radar WebKit Bug Importer
Comment 9 2020-07-15 07:48:15 PDT
<rdar://problem/65605240>
Note You need to log in before you can comment on or make changes to this bug.