Bug 214288

Summary: [macOS] Do not update ScreenTime when in private browsing mode
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eric Carlson
Reported 2020-07-13 17:28:09 PDT
Don't update ScreenTime when in private browsing mode
Attachments
Patch (5.21 KB, patch)
2020-07-13 21:18 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (7.25 KB, patch)
2020-07-14 09:32 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2020-07-13 17:28:51 PDT
<rdar://problem/63735067>
Eric Carlson
Comment 2 2020-07-13 21:18:10 PDT
Created attachment 404208 [details] Patch
Alexey Proskuryakov
Comment 3 2020-07-14 07:29:23 PDT
Comment on attachment 404208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404208&action=review > Source/WebCore/ChangeLog:3 > + [macOS] Do not update ScreenTime when in private browsing mode Why is this ok to do? This sounds like a complete bypass of private browsing restrictions.
Alexey Proskuryakov
Comment 4 2020-07-14 09:00:34 PDT
Comment on attachment 404208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404208&action=review >> Source/WebCore/ChangeLog:3 >> + [macOS] Do not update ScreenTime when in private browsing mode > > Why is this ok to do? This sounds like a complete bypass of private browsing restrictions. Sorry, I meant to say bypass of parental controls.
Alexey Proskuryakov
Comment 5 2020-07-14 09:04:18 PDT
I've been informed that private browsing can't be used under parental controls, so objection removed.
Eric Carlson
Comment 6 2020-07-14 09:32:13 PDT
Created attachment 404242 [details] Patch
EWS
Comment 7 2020-07-14 11:07:28 PDT
Committed r264355: <https://trac.webkit.org/changeset/264355> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404242 [details].
Note You need to log in before you can comment on or make changes to this bug.