Summary: | Update WPT tests for css-text | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, darin, ews-watchlist, mmaxfield, rego, simon.fraser, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=214290 https://bugs.webkit.org/show_bug.cgi?id=214414 |
||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 213927 | ||||||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2020-07-13 14:44:39 PDT
Created attachment 404177 [details]
test patch for EWS, ignore
Created attachment 404203 [details]
Patch
Hopefully all EWS will be green, let's see
Created attachment 404219 [details]
Patch
All green. Asking for review: r? Comment on attachment 404219 [details]
Patch
Thanks.
Again getting issues with the tooling.. when trying to land this manually i get -E2BIG error. $ Tools/Scripts/webkit-patch land -g HEAD Logging in as clopez@igalia.com... Fetching: https://bugs.webkit.org/show_bug.cgi?id=214275&ctype=xml&excludefield=attachmentdata Guessing "Manuel Rego Casasnovas" as reviewer from attachment 404219 [details] on bug 214275. Total errors found: 0 in 6 files COMMIT FAILED: [Errno 7] Argument list too long Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/steps/commit.py", line 89, in run svn_revision = scm.svn_revision_from_commit_text(commit_text) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 106, in svn_revision_from_commit_text return match.group('svn_revision') AttributeError: 'NoneType' object has no attribute 'group' let's try commit-queue to see if that works better Created attachment 404229 [details]
Patch
Patch for landing
Committed r264338: <https://trac.webkit.org/changeset/264338> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404229 [details]. |