Bug 214263

Summary: Crash under WebKit::LaunchServicesDatabaseManager::didConnect()
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, darin, ggaren, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch none

Description Per Arne Vollan 2020-07-13 10:30:55 PDT 
There is a crash under WebKit::LaunchServicesDatabaseManager::didConnect() when trying to send a message to an invalid connection.
Comment 1 Per Arne Vollan 2020-07-13 10:33:56 PDT 
Created attachment 404154 [details]
Patch
Comment 2 Per Arne Vollan 2020-07-13 10:36:31 PDT 
Created attachment 404155 [details]
Patch
Comment 3 Darin Adler 2020-07-13 10:52:21 PDT 
Comment on attachment 404155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404155&action=review

> Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:70
> +    auto conn = connection();

WebKit coding style says:

    auto connection = this->connection();
Comment 4 Per Arne Vollan 2020-07-13 11:34:08 PDT 
Created attachment 404161 [details]
Patch
Comment 5 Per Arne Vollan 2020-07-13 11:34:43 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 404155 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404155&action=review
> 
> > Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:70
> > +    auto conn = connection();
> 
> WebKit coding style says:
> 
>     auto connection = this->connection();

Fixed.

Thanks for reviewing!
Comment 6 EWS 2020-07-13 12:13:09 PDT 
Committed r264309: <https://trac.webkit.org/changeset/264309>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404161 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-13 12:14:15 PDT 
<rdar://problem/65492080>
Comment 8 Per Arne Vollan 2020-07-13 12:35:42 PDT 
*** Bug 214200 has been marked as a duplicate of this bug. ***
Comment 9 Ryan Haddad 2020-07-13 12:42:11 PDT 
*** Bug 214227 has been marked as a duplicate of this bug. ***