Bug 214254

Summary: Skip intermittently failing type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value on mips
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, jsc32, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Angelos Oikonomopoulos
Reported 2020-07-13 06:36:00 PDT
Skip intermittently failing type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value on mips
Attachments
Patch (700 bytes, patch)
2020-07-13 06:36 PDT, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (700 bytes, patch)
2020-07-13 08:27 PDT, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (725 bytes, patch)
2020-07-14 03:47 PDT, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (1.36 KB, patch)
2020-07-14 03:48 PDT, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2020-07-13 06:36:18 PDT
Created attachment 404144 [details] Patch
Angelos Oikonomopoulos
Comment 2 2020-07-13 08:27:02 PDT
Created attachment 404149 [details] Patch
Carlos Alberto Lopez Perez
Comment 3 2020-07-14 03:22:32 PDT
Comment on attachment 404149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404149&action=review > JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js:1 > +//@ skip if (not $jitTests or ["mips"].include?($architecture)) nitpick: those extra parenthesis are not needed
EWS
Comment 4 2020-07-14 03:23:08 PDT
Unable to find any modified ChangeLog in Attachment 404149 [details]
Carlos Alberto Lopez Perez
Comment 5 2020-07-14 03:25:17 PDT
And you need to provide a changelog. Use the script prepare-changelog for that. Example of use: Tools/Scripts/prepare-ChangeLog -b 214254 -g $localcommitgithashforthispatch
Angelos Oikonomopoulos
Comment 6 2020-07-14 03:47:16 PDT
Created attachment 404220 [details] Patch
Angelos Oikonomopoulos
Comment 7 2020-07-14 03:48:48 PDT
Created attachment 404221 [details] Patch
Angelos Oikonomopoulos
Comment 8 2020-07-14 03:51:18 PDT
Oops, hopefully fixed now.
Carlos Alberto Lopez Perez
Comment 9 2020-07-14 04:02:25 PDT
Comment on attachment 404221 [details] Patch thanks!
EWS
Comment 10 2020-07-14 04:26:35 PDT
Committed r264336: <https://trac.webkit.org/changeset/264336> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404221 [details].
Radar WebKit Bug Importer
Comment 11 2020-07-14 04:27:14 PDT
<rdar://problem/65533960>
Note You need to log in before you can comment on or make changes to this bug.