Bug 214129 – Local internal builds fail on Apple Silicon (building yasm)

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

Local internal builds fail on Apple Silicon (building yasm)

[Tim Horton]

Created attachment 403856 [details]
Patch

Comment on attachment 403856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403856&action=review

> Tools/Scripts/webkitdirs.pm:375
> +    if (isAppleCocoaWebKit() && $output eq "arm64") {

Could combine with the above into one `if (isAppleCocoaWebKit())` block.

> Tools/Scripts/webkitdirs.pm:376
> +        $output = determineXcodeSDK();

Why are we assigning an SDK identifier to `$output` (which appears to hold an architecture) here?

[Tim Horton]

Comment on attachment 403856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403856&action=review

>> Tools/Scripts/webkitdirs.pm:375
>> +    if (isAppleCocoaWebKit() && $output eq "arm64") {
> 
> Could combine with the above into one `if (isAppleCocoaWebKit())` block.

I intentionally did not because the above block will go away and this one won’t.

>> Tools/Scripts/webkitdirs.pm:376
>> +        $output = determineXcodeSDK();
> 
> Why are we assigning an SDK identifier to `$output` (which appears to hold an architecture) here?

Whoops! That was for debugging and I forgot to revert. Good catch.

[Tim Horton]

Created attachment 403887 [details]
Patch

[EWS]

Committed r264182: <https://trac.webkit.org/changeset/264182>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403887 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65281288>

[Jonathan Bedard]

Comment on attachment 403887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403887&action=review

> Tools/Scripts/webkitdirs.pm:381
> +

We need to make sure that run-javascriptcore-tests will override arm64e with arm64. I think it already does, but I don’t have a checkout handy.